Conversation
Added additional fields for the DirectHit algorithm in the documentation.
Added additional fields required for the DirectHit algorithm.
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些高层面的反馈：
- 像
Same as DirectHit.roi和DirectHit.roi_offset这样的新引用依赖读者已经知道DirectHit在哪里被定义；建议把这些引用改成显式链接，或者添加一个锚点，方便读者快速跳转到权威定义处。 - 在 ROI 描述中使用 💡 表情符号与文档其他部分偏正式的风格不太一致；为保持一致性，建议改用纯文本（例如
Note (v5.6): ...）。
给 AI 代理的提示词
Please address the comments from this code review:
## Overall Comments
- The new references like `Same as DirectHit.roi` and `DirectHit.roi_offset` rely on the reader knowing where `DirectHit` is defined; consider turning these into explicit links or adding an anchor so it’s easy to jump to the canonical definition.
- The use of the 💡 emoji in the ROI description is inconsistent with the otherwise formal style of the docs; consider replacing it with plain text (e.g., `Note (v5.6): ...`) for consistency.帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- The new references like
Same as DirectHit.roiandDirectHit.roi_offsetrely on the reader knowing whereDirectHitis defined; consider turning these into explicit links or adding an anchor so it’s easy to jump to the canonical definition. - The use of the 💡 emoji in the ROI description is inconsistent with the otherwise formal style of the docs; consider replacing it with plain text (e.g.,
Note (v5.6): ...) for consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new references like `Same as DirectHit.roi` and `DirectHit.roi_offset` rely on the reader knowing where `DirectHit` is defined; consider turning these into explicit links or adding an anchor so it’s easy to jump to the canonical definition.
- The use of the 💡 emoji in the ROI description is inconsistent with the otherwise formal style of the docs; consider replacing it with plain text (e.g., `Note (v5.6): ...`) for consistency.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由 Sourcery 提供的摘要
在管线协议中明确 ROI、box 和 target 的语义，并通过引用 DirectHit 的定义来统一识别算法中 ROI 配置的文档说明。
文档更新：
roi、box和target字段在概念上的差异以及典型的处理流程。roi和roi_offset参数说明，并在英文和中文的协议文档中，通过交叉引用的方式，将该定义复用于其他识别算法。Original summary in English
Summary by Sourcery
Document the semantics of ROI, box, and target in the pipeline protocol and centralize ROI configuration documentation for recognition algorithms by referencing the DirectHit definition.
Documentation:
roi,box, andtargetfields in image recognition actions.roiandroi_offsetparameters for DirectHit and reuse this definition across other recognition algorithms via cross-references in both English and Chinese protocol docs.