Merged
Conversation
Contributor
There was a problem hiding this comment.
嗨,我已经审查了你的修改,看起来非常不错!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在为 MaaFramework Project Interface(PI)新增并落地 group(任务分组)能力:在 interface.json 声明分组元信息、在各任务文件中标注所属分组,并补齐多语言文案与 Schema 支持。
Changes:
- 在
tools/schema/interface.schema.json中新增顶层group与task.group的 Schema 定义,并更新import字段说明 - 在
assets/interface.json中新增分组声明(daily/foreground/realtime/utility),并为多个任务增加group标注 - 在各语言 locale 中新增
group.*的 label/description 文案
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/schema/interface.schema.json | 新增 groupItem、顶层 group 与 taskItem.group 定义,并更新 import 描述 |
| assets/interface.json | 增加分组配置并调整导入任务列表顺序 |
| assets/tasks/Weapon.json | 为任务添加 group: ["daily"] |
| assets/tasks/VisitFriends.json | 为任务添加 group: ["daily"] |
| assets/tasks/SimpleProductionBatchStart.json | 为任务添加 group: ["daily"] |
| assets/tasks/SellProduct.json | 为任务添加 group: ["daily"] |
| assets/tasks/SeizeEntrustTask.json | 为任务添加 group: ["daily"] |
| assets/tasks/ReceiveProdManual.json | 为任务添加 group: ["daily"] |
| assets/tasks/RealTimeTask.json | 为任务添加 group: ["realtime"] |
| assets/tasks/ReadAllWiki.json | 为任务添加 group: ["utility"] |
| assets/tasks/PuzzleSolver.json | 为任务添加 group: ["utility"] |
| assets/tasks/ProtocolSpace.json | 为任务添加 group: ["foreground"] |
| assets/tasks/ItemTransfer.json | 为任务添加 group: ["utility"] |
| assets/tasks/ImportBluePrints.json | 为任务添加 group: ["utility"] |
| assets/tasks/GiftOperator.json | 为任务添加 group: ["foreground"] |
| assets/tasks/GearAssembly.json | 为任务添加 group: ["daily"] |
| assets/tasks/EssenceFilter.json | 为任务添加 group: ["utility"] |
| assets/tasks/EnvironmentMonitoring.json | 为任务添加 group: ["foreground"] |
| assets/tasks/DijiangRewards.json | 为任务添加 group: ["daily"] |
| assets/tasks/DeliveryJobs.json | 为任务添加 group: ["daily"] |
| assets/tasks/DailyRewards.json | 为任务添加 group: ["daily"] |
| assets/tasks/CreditShopping.json | 为任务添加 group: ["daily"] |
| assets/tasks/Crafting.json | 为任务添加 group: ["daily"] |
| assets/tasks/ClaimSimulationRewards.json | 为任务添加 group: ["daily"] |
| assets/tasks/BatchAddFriends.json | 为任务添加 group: ["utility"] |
| assets/tasks/BakerEntry.json | 为任务添加 group: ["utility"] |
| assets/tasks/AutoUseSpMedication.json | 为任务添加 group: ["utility"] |
| assets/tasks/AutoResell.json | 为任务添加 group: ["daily"] |
| assets/tasks/AutoEssence.json | 为任务添加 group: ["foreground"] |
| assets/tasks/AutoEcoFarm.json | 为任务添加 group: ["foreground"] |
| assets/tasks/AndroidOpenGame.json | 为任务添加 group: ["utility"] |
| assets/misc/locales/zh_tw.json | 新增分组的繁中显示文案 |
| assets/misc/locales/zh_cn.json | 新增分组的简中显示文案 |
| assets/misc/locales/ko_kr.json | 新增分组的韩文显示文案 |
| assets/misc/locales/ja_jp.json | 新增分组的日文显示文案 |
| assets/misc/locales/en_us.json | 新增分组的英文显示文案 |
Contributor
|
我认为简制手册一键领取和批量简易制作应该属于实用工具类,因为并不需要每天运行,而且批量简易制作是需要手动选择造哪个的,其他没有什么问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ocsin1 帮我瞅瞅()
Summary by Sourcery
在各类配置和模式(schema)文件中调整 task 和 interface 定义,以支持新的 PI
group字段。新功能:
group元数据,用于对任务进行分类或分组。group字段。增强项:
group字段的新增或使用情况。Original summary in English
Summary by Sourcery
Adapt task and interface definitions to support the new PI
groupfield across configuration and schema files.New Features:
groupmetadata to task configuration JSONs for categorizing or grouping tasks.groupfield in the interface definition and its JSON schema.Enhancements:
groupfield in the UI.