fix(essencefilter): migrate all logs to zerolog structured fields#1127
Merged
Joe-Bao merged 2 commits intofix/essencefrom Mar 8, 2026
Merged
fix(essencefilter): migrate all logs to zerolog structured fields#1127Joe-Bao merged 2 commits intofix/essencefrom
Joe-Bao merged 2 commits intofix/essencefrom
Conversation
Co-authored-by: Joe-Bao <114393786+Joe-Bao@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ability entry display issue in third line recognition
fix(essencefilter): migrate all logs to zerolog structured fields
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 45 log statements in
actions.goused<EssenceFilter>prefixes and embedded context (rule names, step labels) directly inMsg, violating the go-service zerolog convention.Changes
<EssenceFilter>prefix from everyMsgstringStr("component", "EssenceFilter")to all log callsStr("rule", "MatchSlot3Level3Practical")/Str("rule", "MatchFuturePromising")Str("step", "LoadMatcherConfig")/"LoadDatabase"/"LoadOptions"/"ValidatePresets"/"FilterWeapons"/"BuildSkillCombinations"(descriptive names instead ofStep2–Step7)Str("action", "CheckTotal")/"RowCollect"/"RowNextItem"/"CheckItem"Before / after example:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.