Skip to content

DICOM: Performance fix to wildcard matching#3208

Merged
jdtournier merged 2 commits intomasterfrom
wildcard_stringmatch_fix
Oct 7, 2025
Merged

DICOM: Performance fix to wildcard matching#3208
jdtournier merged 2 commits intomasterfrom
wildcard_stringmatch_fix

Conversation

@Lestropie
Copy link
Copy Markdown
Member

Error in 8e3612a as part of #1929.

I expect this to be of no consequence to behaviour, so not even applying the bug tag; it's just preventing unnecessary recursive construction of std::string's.

(This will be better addressed using std::string_view on dev; that's how I found it)

@Lestropie Lestropie requested a review from jdtournier October 7, 2025 00:25
@Lestropie Lestropie self-assigned this Oct 7, 2025
Copy link
Copy Markdown
Member

@jdtournier jdtournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@jdtournier jdtournier enabled auto-merge October 7, 2025 08:03
@jdtournier jdtournier added this pull request to the merge queue Oct 7, 2025
Merged via the queue into master with commit fcd0742 Oct 7, 2025
5 checks passed
@jdtournier jdtournier deleted the wildcard_stringmatch_fix branch October 7, 2025 09:02
@jdtournier jdtournier mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants