Docs: New page on MRView "lock to image axes"#2882
Merged
Conversation
jdtournier
approved these changes
Apr 22, 2024
Member
jdtournier
left a comment
There was a problem hiding this comment.
Looks great, thanks for putting in the effort! It was long overdue...
I just fixed a couple of typos, but otherwise it's really nice work!
Member
Author
|
Requires review by a third party: @jdtournier's review does not satisfy requirement for merge due to being the author of the last commit. |
daljit46
approved these changes
Apr 23, 2024
Member
daljit46
left a comment
There was a problem hiding this comment.
Small typo on line 48 I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a long-standing confound with image visualisation that we have regularly attempted to describe but never invested the effort in properly documenting and explaining. Possibly because #452 would be a whole lot more fun. But for a pending article submission with @jdtournier it would be beneficial to be able to provide a hyperlink to a documentation page where the issue is explained, rather than trying to shoehorn in there an inadequate explanation.
Rendered docs link:
https://mrtrix3-dev.readthedocs.io/en/docs_mrview_lock_axes/concepts/mrview_lock_axes/mrview_lock_axes.html