You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normally I'd opt to do this as a regular merge of master into dev. However with cmake & clang-format being on dev now this is a very unclean merge. So I think maybe we'll just redo the copyright update on dev separately, and any fixes on master that need to make their way to dev (which is not all of them) can be individually merged / cherry-picked.
We'll need to do the merge properly at some point anyway, otherwise we simply won't be able to merge back to master when we eventually release. I reckon it's best to do the messy work now, otherwise it'll only get worse over time. Personally, I think we need to do a merge of master back to dev back now.
It's possible that for something like update_copyright, running separately on each branch prior to merging might give git merge a bit of a helping hand in terms of reducing the scope of conflicts. I'll have to check the other PRs that have since gone to master to see the scope of those. A naive git merge produced a much larger conflict than what I would have expected, probably due to differences in indentation. Manually cherry-picking each PR onto dev and then accepting local in the merge conflict might be the way to go, to make sure that no desired changes are lost in the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary update for successful merging of any new changes to
master.