Merged
Conversation
Lestropie
approved these changes
Oct 5, 2023
Member
Lestropie
left a comment
There was a problem hiding this comment.
Looks to be rendering correctly.
What's not evaluated here is compilation of non-HTML versions of the documentation. We'd previously discussed bundling these with pre-compiled binary downloads. But not sure that this capability is currently in use anywhere. Would rather fix the online docs now, and if there's issues elsewhere that can be raised standalone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resorted to re-generating a default Sphinx config, and adding back the bits we specifically needed. Seems to fix the render issues we were having. I'm not sure what caused the problem exactly, but the config files are now considerably simpler, which is no bad thing...
See rendered version of this branch on ReadThedocs:
https://mrtrix.readthedocs.io/en/fix_readthedocs_render/