Move fetch-store functions out of image_io and generalise#2436
Merged
Conversation
- Move files fetch_store.* from core/image_io/ to core/. - Rename some functions to reflect the fact that they perform a linear transform of intensities in addition to fetching or storing raw data. - Add new functions that provide access to such template functions but without the use of that linear transformation, which tends to be specific to image data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low priority for review, just putting up as a draft PR in case you want to pass judgement.
I'd already encountered this in the past when I implemented PNG support, which slightly unintuitively depends on relying on the same functionality used to determine the template functions for accessing and transforming image intensities. Now I've got a different use case, where I need to be able to define functions for converting between many possible pairs of data types and capture the requisite function in a
std::functionbased on a template parameter and aDataType, but those data have nothing to do with images, and there's no need for the linear transform.