Merged
Conversation
Python3 on TravisCI have introduced new tests with pylint 2.4.0. This change should permit testing on master to pass: - Use sys.exit() rather than exit(). - Remove some unnecessary comprehensions in dwipreproc. - Tweak run_pylint script to not print erroneous warnings due to cache directories or empty directories left over from checking out other branches. - Ignore import-outside-toplevel; given the overhaul of the Python API in #1449 conformance with this recommendation will instead be performed on the dev branch.
Based on online recommendations. Commit follows f9d1d54.
pylint 2.4.0 in Python3 gives a new warning "consider-using-sys-exit". By explicitly disabling this warning, pylint on Python 2 instead complains that this is a bad option value. Furthermore, the preferred exit() call for the signal handler invokes a protected function of the os module. This change removes the sys.exit() disable, and instead disables the protected-member warning.
Member
Author
|
This passes CI, and needs a review in order for other PR merges to |
Closed
jdtournier
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging of this PR will be necessary before other PRs targeting the
masterbranch can pass CI testing. Details in f9d1d54 commit message.