Progressbar restrict construction to main thread#1707
Merged
Conversation
Member
Author
|
OK, I guess this isn't going to be looked at unless I un-draft it... Everyone happy to merge and see what happens...? |
Lestropie
approved these changes
Nov 22, 2019
Member
Lestropie
left a comment
There was a problem hiding this comment.
Progress bars have already been a bit buggy on dev in recent past, so yeah I figure just merge it in and see what happens; dev should be getting a bit of a workout right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion on #1703 and #263.
Still need to figure out whether there are instances where this is going to be problematic - hence this remains a draft for now.