Skip to content

Handle shell selection when using msmt_csd#1082

Merged
thijsdhollander merged 1 commit intotag_3.0_RC2from
dwi2fod-shell-option
Aug 8, 2017
Merged

Handle shell selection when using msmt_csd#1082
thijsdhollander merged 1 commit intotag_3.0_RC2from
dwi2fod-shell-option

Conversation

@bjeurissen
Copy link
Copy Markdown
Member

This should address issue #1081

Copy link
Copy Markdown
Contributor

@thijsdhollander thijsdhollander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks like it should do the trick. I can confirm the triple "false" options to select_shells is correct (I've done some major redesigning on the logic of that function a while ago when dwi2response got some significant changes during the 0.3.16 development days). All "false" options there basically does no automatic stuff, and fully honours the -shell option without constraints; just the way we want it for a generic MSMT-CSD without assumptions about the scenarios that users want to test. I'll merge this in right now, so it's included in RC2 out of the box.

@thijsdhollander thijsdhollander merged commit 9635243 into tag_3.0_RC2 Aug 8, 2017
@thijsdhollander thijsdhollander deleted the dwi2fod-shell-option branch August 8, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants