Handle shell selection when using msmt_csd#1082
Merged
thijsdhollander merged 1 commit intotag_3.0_RC2from Aug 8, 2017
Merged
Conversation
This should address issue #1081
thijsdhollander
approved these changes
Aug 8, 2017
Contributor
thijsdhollander
left a comment
There was a problem hiding this comment.
Yep, that looks like it should do the trick. I can confirm the triple "false" options to select_shells is correct (I've done some major redesigning on the logic of that function a while ago when dwi2response got some significant changes during the 0.3.16 development days). All "false" options there basically does no automatic stuff, and fully honours the -shell option without constraints; just the way we want it for a generic MSMT-CSD without assumptions about the scenarios that users want to test. I'll merge this in right now, so it's included in RC2 out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address issue #1081