refactor: fix CSS class naming and remove duplicate method

jimmyn · jimmyn · commit ea72233f4150 · 2025-10-10T14:23:17.000+02:00
- Fix Account ID field CSS classes (monei-api-key-field → monei-account-id-field)
- Update JavaScript to toggle both Account ID and API Key fields
- Remove duplicate get_frontend_generated_monei_token() from WCMoneiPaymentGatewayComponent (inherits from parent)
diff --git a/assets/js/monei-settings.js b/assets/js/monei-settings.js
@@ -1,13 +1,21 @@
 jQuery( document ).ready( function ( $ ) {
-	// Function to toggle API key fields
+	// Function to toggle API key and Account ID fields
 	function toggleApiKeyFields() {
 		const mode = $( '#monei_apikey_mode' ).val();
 		if ( mode === 'test' ) {
-			$( '.monei-test-api-key-field' ).closest( 'tr' ).show();
-			$( '.monei-live-api-key-field' ).closest( 'tr' ).hide();
+			$( '.monei-test-api-key-field, .monei-test-account-id-field' )
+				.closest( 'tr' )
+				.show();
+			$( '.monei-live-api-key-field, .monei-live-account-id-field' )
+				.closest( 'tr' )
+				.hide();
 		} else {
-			$( '.monei-test-api-key-field' ).closest( 'tr' ).hide();
-			$( '.monei-live-api-key-field' ).closest( 'tr' ).show();
+			$( '.monei-test-api-key-field, .monei-test-account-id-field' )
+				.closest( 'tr' )
+				.hide();
+			$( '.monei-live-api-key-field, .monei-live-account-id-field' )
+				.closest( 'tr' )
+				.show();
 		}
 	}
 
diff --git a/src/Gateways/Abstracts/WCMoneiPaymentGatewayComponent.php b/src/Gateways/Abstracts/WCMoneiPaymentGatewayComponent.php
@@ -297,16 +297,6 @@ public function create_payload( $order, $allowed_payment_method = null ) {
 		return $payload;
 	}
 
-	/**
-	 * Frontend MONEI generated token.
-	 *
-	 * @return false|string
-	 */
-	public function get_frontend_generated_monei_token() {
-		// phpcs:ignore WordPress.Security.NonceVerification, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-		return ( isset( $_POST['monei_payment_token'] ) ) ? wc_clean( wp_unslash( $_POST['monei_payment_token'] ) ) : false;  // WPCS: CSRF ok.
-	}
-
 	/**
 	 * Frontend MONEI generated flag for block checkout processing.
 	 *
diff --git a/src/Settings/MoneiSettings.php b/src/Settings/MoneiSettings.php
@@ -46,7 +46,7 @@ public function get_settings() {
 				'desc'        => __( 'Your MONEI Test Account ID. Available at your MONEI dashboard.', 'monei' ),
 				'id'          => 'monei_test_accountid',
 				'default'     => '',
-				'class'       => 'monei-api-key-field monei-test-api-key-field',
+				'class'       => 'monei-account-id-field monei-test-account-id-field',
 				'placeholder' => '9b1deb4d-3b7d-4bad-9bdd-2b0c11b3dcb6d',
 			),
 			array(
@@ -55,7 +55,7 @@ public function get_settings() {
 				'desc'        => __( 'Your MONEI Account ID. Available at your MONEI dashboard.', 'monei' ),
 				'id'          => 'monei_live_accountid',
 				'default'     => '',
-				'class'       => 'monei-api-key-field monei-live-api-key-field',
+				'class'       => 'monei-account-id-field monei-live-account-id-field',
 				'placeholder' => 'f47ac10b-58cc-4372-a567-0e02b2c3d479',
 			),
 			array(
