fix: use correct option key for order completion setting in redirect

jimmyn · jimmyn · commit d9d2c41dba88 · 2025-10-10T09:09:40.000+02:00
Changed from $order-&gt;get_payment_method() to monei_get_option_key_from_order($order)
to match IPN handler pattern. This ensures the "mark completed" preference is correctly
checked for all payment methods.
diff --git a/includes/class-wc-monei-redirect-hooks.php b/includes/class-wc-monei-redirect-hooks.php
@@ -258,8 +258,7 @@ private function verify_and_complete_order( $order_id, $payment ) {
 				$order->add_order_note( $order_note );
 				$order->payment_complete();
 
-				$payment_method_woo_id = $order->get_payment_method();
-				if ( 'completed' === monei_get_settings( 'orderdo', $payment_method_woo_id ) ) {
+				if ( 'completed' === monei_get_settings( 'orderdo', monei_get_option_key_from_order( $order ) ) ) {
 					$order->update_status( 'completed', __( 'Order Completed by MONEI', 'monei' ) );
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -258,8 +258,7 @@ private function verify_and_complete_order( $order_id, $payment ) {`
`258`	`258`	`$order->add_order_note( $order_note );`
`259`	`259`	`$order->payment_complete();`
`260`	`260`
`261`		`- $payment_method_woo_id = $order->get_payment_method();`
`262`		`- if ( 'completed' === monei_get_settings( 'orderdo', $payment_method_woo_id ) ) {`
	`261`	`+ if ( 'completed' === monei_get_settings( 'orderdo', monei_get_option_key_from_order( $order ) ) ) {`
`263`	`262`	`$order->update_status( 'completed', __( 'Order Completed by MONEI', 'monei' ) );`
`264`	`263`	`}`
`265`	`264`	`}`