Return boolean when cart has subscription with yith

malmo-monei · malmo-monei · commit 5852018552f2 · 2025-04-29T13:44:39.000+02:00
diff --git a/src/Features/Subscriptions/YithSubscriptionPluginHandler.php b/src/Features/Subscriptions/YithSubscriptionPluginHandler.php
@@ -306,15 +306,13 @@ public function get_subscription_payment_method_friendly_name( $subscription ) {
      * @return bool
      */
     function cart_has_subscription() {
-        // Ensure YITH WooCommerce Subscription plugin is active
+
         if (!function_exists('YITH_WC_Subscription')) {
             return false;
         }
 
-        // Get the YITH_WC_Subscription instance
         $ywsbs = YITH_WC_Subscription();
 
-        // Use the is_subscription method to check if the product is a subscription
-        return $ywsbs->cart_has_subscriptions();
+        return is_string($ywsbs->cart_has_subscriptions());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -306,15 +306,13 @@ public function get_subscription_payment_method_friendly_name( $subscription ) {`
`306`	`306`	`* @return bool`
`307`	`307`	`*/`
`308`	`308`	`function cart_has_subscription() {`
`309`		`- // Ensure YITH WooCommerce Subscription plugin is active`
	`309`	`+`
`310`	`310`	`if (!function_exists('YITH_WC_Subscription')) {`
`311`	`311`	`return false;`
`312`	`312`	`}`
`313`	`313`
`314`		`- // Get the YITH_WC_Subscription instance`
`315`	`314`	`$ywsbs = YITH_WC_Subscription();`
`316`	`315`
`317`		`- // Use the is_subscription method to check if the product is a subscription`
`318`		`- return $ywsbs->cart_has_subscriptions();`
	`316`	`+ return is_string($ywsbs->cart_has_subscriptions());`
`319`	`317`	`}`
`320`	`318`	`}`