fix: improve payment method description field behavior and consistency

jimmyn · jimmyn · commit 32cb917f8677 · 2025-10-03T09:10:29.000+02:00
- Add conditional description display for card payment method
- Update card description default to include 'Powered by MONEI' branding
- Remove MBWay and Multibanco from conditional display (redirect-only methods)
- Update MBWay and Multibanco description help text to reflect always-visible behavior

Changes:
- Card, PayPal, Bizum: Description shown only in redirect mode
- MBWay, Multibanco: Description always visible (redirect-only methods)
- All methods now have consistent 'Powered by MONEI' branding in defaults
diff --git a/assets/js/monei-settings.js b/assets/js/monei-settings.js
@@ -29,8 +29,9 @@ jQuery( document ).ready( function ( $ ) {
 		}
 	}
 
-	// Payment methods that have description fields
-	const paymentMethods = ['paypal', 'bizum', 'mbway', 'multibanco'];
+	// Payment methods that have description fields (only for methods with both redirect and embedded modes)
+	// MBWay and Multibanco are redirect-only, so their descriptions are always visible
+	const paymentMethods = ['cc', 'paypal', 'bizum'];
 
 	// Initial call to set the correct fields on page load
 	toggleApiKeyFields();
diff --git a/includes/admin/monei-cc-settings.php b/includes/admin/monei-cc-settings.php
@@ -44,7 +44,7 @@
 			'title'       => __( 'Description', 'monei' ),
 			'type'        => 'textarea',
 			'description' => __( 'This description is only displayed when using redirect mode. It will be shown to customers before they are redirected to the payment page.', 'monei' ),
-			'default'     => __( 'Pay with credit card.', 'monei' ),
+			'default'     => __( 'Pay with credit card. Powered by MONEI.', 'monei' ),
 			'class'       => 'monei-cc-description-field',
 		),
 		'card_input_style' => array(
diff --git a/includes/admin/monei-mbway-settings.php b/includes/admin/monei-mbway-settings.php
@@ -43,7 +43,7 @@
 		'description' => array(
 			'title'       => __( 'Description', 'monei' ),
 			'type'        => 'textarea',
-			'description' => __( 'This description is only displayed when using redirect mode. It will be shown to customers before they are redirected to the payment page.', 'monei' ),
+			'description' => __( 'Payment method description shown to customers during checkout.', 'monei' ),
 			'default'     => __( 'Pay with MBWay. Powered by MONEI.', 'monei' ),
 			'class'       => 'monei-mbway-description-field',
 		),
diff --git a/includes/admin/monei-multibanco-settings.php b/includes/admin/monei-multibanco-settings.php
@@ -43,7 +43,7 @@
 		'description' => array(
 			'title'       => __( 'Description', 'monei' ),
 			'type'        => 'textarea',
-			'description' => __( 'This description is only displayed when using redirect mode. It will be shown to customers before they are redirected to the payment page.', 'monei' ),
+			'description' => __( 'Payment method description shown to customers during checkout.', 'monei' ),
 			'default'     => __( 'Pay with Multibanco. Powered by MONEI.', 'monei' ),
 			'class'       => 'monei-multibanco-description-field',
 		),

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,9 @@ jQuery( document ).ready( function ( $ ) {`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`
`32`		`- // Payment methods that have description fields`
`33`		`- const paymentMethods = ['paypal', 'bizum', 'mbway', 'multibanco'];`
	`32`	`+ // Payment methods that have description fields (only for methods with both redirect and embedded modes)`
	`33`	`+ // MBWay and Multibanco are redirect-only, so their descriptions are always visible`
	`34`	`+ const paymentMethods = ['cc', 'paypal', 'bizum'];`
`34`	`35`
`35`	`36`	`// Initial call to set the correct fields on page load`
`36`	`37`	`toggleApiKeyFields();`