Webpack Integration#53
Merged
gladishd merged 1 commit intoMLH-Fellowship:mainfrom Apr 15, 2021
Merged
Conversation
gladishd
approved these changes
Apr 15, 2021
Collaborator
gladishd
left a comment
There was a problem hiding this comment.
This is hands down the best thing I have ever seen in terms of Webpack bundling. It's pretty clear how he's using Webpack instead of TypeScript to bundle the extension into ./dist/extension.js, being careful to include the file extension at the end. I have never seen anything like it, why wouldn't you approve this for Shrill this is amazing! Remember that this is all about his ability to conceptualize how the TS ./out/compiled should be working. Look and see!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used the webpack for bundling extension.
Contributors:
@gladishd
@ShrillShrestha