Skip to content

Webpack Integration#53

Merged
gladishd merged 1 commit intoMLH-Fellowship:mainfrom
ShrillShrestha:webpack-integrate
Apr 15, 2021
Merged

Webpack Integration#53
gladishd merged 1 commit intoMLH-Fellowship:mainfrom
ShrillShrestha:webpack-integrate

Conversation

@ShrillShrestha
Copy link
Copy Markdown
Contributor

Used the webpack for bundling extension.

Contributors:
@gladishd
@ShrillShrestha

Copy link
Copy Markdown
Collaborator

@gladishd gladishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hands down the best thing I have ever seen in terms of Webpack bundling. It's pretty clear how he's using Webpack instead of TypeScript to bundle the extension into ./dist/extension.js, being careful to include the file extension at the end. I have never seen anything like it, why wouldn't you approve this for Shrill this is amazing! Remember that this is all about his ability to conceptualize how the TS ./out/compiled should be working. Look and see!

@gladishd gladishd merged commit 3eefee4 into MLH-Fellowship:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants