Skip to content

Added Github Stats and Most Used Languages#41

Merged
robzwolf merged 7 commits intoMLH-Fellowship:mainfrom
Inoxia25:main
Jul 22, 2021
Merged

Added Github Stats and Most Used Languages#41
robzwolf merged 7 commits intoMLH-Fellowship:mainfrom
Inoxia25:main

Conversation

@Inoxia25
Copy link
Copy Markdown
Member

@Inoxia25 Inoxia25 commented Jul 21, 2021

Why This PR Adds Value

This PR gives more idea about the users contributions and most used languages on Github

What This PR Adds

  • This PR adds a github stats card, which shows the the users commit history and contributions.
  • This PR also adds a most languages card, which shows the 4 most used languages by the user on their Github Profile.

Screenshot

Screenshot of portfolio

Issue This PR Closes

This closes #29

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 21, 2021

✔️ Deploy Preview for practically-pi-portfolio-template ready!

🔨 Explore the source changes: d9de09a

🔍 Inspect the deploy log: https://app.netlify.com/sites/practically-pi-portfolio-template/deploys/60f876bdf79e950008c3f430

😎 Browse the preview: https://deploy-preview-41--practically-pi-portfolio-template.netlify.app/

@Inoxia25 Inoxia25 requested a review from robzwolf July 21, 2021 11:54
@louisefindlay23 louisefindlay23 self-requested a review July 21, 2021 14:32
Copy link
Copy Markdown
Member

@louisefindlay23 louisefindlay23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, @Inoxia25. Looks great. Love the most used languages card you added. On smaller screens, the cards are bunched together, so it would be good to add a margin in a media query to account for this. See image below.

Portfolio Github Stats card

If you wanted to extend it, maybe try and style the Github Stats card to match the colour scheme of the portfolio ?

@Inoxia25
Copy link
Copy Markdown
Member Author

@louisefindlay23 hey changed the color scheme for the github stat card
image
do let me know if any other changes are required!

@Inoxia25 Inoxia25 requested a review from louisefindlay23 July 21, 2021 15:30
@louisefindlay23
Copy link
Copy Markdown
Member

louisefindlay23 commented Jul 21, 2021

Awesome work on the colour scheme. Still see the margin issue. Will chat further in our 1 on 1.

Copy link
Copy Markdown
Member

@louisefindlay23 louisefindlay23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be it resolved. :) Needed to be .github-stats img instead of the container class. Lovely conversation. Great to hear about your experiences and was great to chat about uni and hackathons.

@Inoxia25
Copy link
Copy Markdown
Member Author

@louisefindlay23 yup it was so great talking to you! Thank you for all the recommendations!
I think we have got a conflicting issue in our config.yml file due to the github username change 😢

@louisefindlay23
Copy link
Copy Markdown
Member

Should be an easy fix. Will take a look after standup

@louisefindlay23
Copy link
Copy Markdown
Member

Hmm, I can't look because I don't have write access or are PR author but basically install Refined Github then go to Extension Settings and generate a Github token, paste it into the field and then go to resolve conflicts in the web editor.

@louisefindlay23
Copy link
Copy Markdown
Member

May do my talk on Git Merge Conflicts since it seems to be a topic of high interest and hopefully be very useful unless I learn some new and interesting new thing before then. Learned about ternary operators in JS but not sure if I can make a 10 min talk about it since I haven't had the change to use them yet.

@dtemir
Copy link
Copy Markdown
Member

dtemir commented Jul 22, 2021

@Inoxia25 looks sharp.

For the dark mode toggler, I think we should look into modifying the Vercel URL from
https://github-readme-stats.vercel.app/api?username=wrussell1999&show_icons=true&theme=default to https://github-readme-stats.vercel.app/api?username=wrussell1999&show_icons=true&theme=dark, based on whether the dark mode is activated.

I'll wait until the PR gets merged and then try come up with a scrip to modify the url (feel free to try it too if you want)

Copy link
Copy Markdown
Member

@robzwolf robzwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@robzwolf robzwolf merged commit 15332dd into MLH-Fellowship:main Jul 22, 2021
@Inoxia25
Copy link
Copy Markdown
Member Author

Inoxia25 commented Jul 22, 2021

@louisefindlay23 yes sounds like a plan! Who else to learn about git merge from than the git princess herself! 👑

@Inoxia25
Copy link
Copy Markdown
Member Author

@dtemir yup would look great! there are actually many themes available for the github stat card, so once we decide the color scheme for the dark mode, we can choose accordingly 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Stats

4 participants