Skip to content

implement blinking microphone icon#60

Merged
suhanichawla merged 4 commits intoMLH-Fellowship:mainfrom
n-maido:main
Apr 16, 2021
Merged

implement blinking microphone icon#60
suhanichawla merged 4 commits intoMLH-Fellowship:mainfrom
n-maido:main

Conversation

@n-maido
Copy link
Copy Markdown
Member

@n-maido n-maido commented Apr 15, 2021

Addresses issue #55

  • Display a microphone icon when space is pressed or voice input is active
  • The microphone has a blinking green circle
  • Can be found in ACE/src/chess/Microphone

Gif:
(the gif is pixelated, but it doesn't look that way in the browser!)
microphone-screen-recording

cc @saum7800 @suhanichawla @atreyamaj

Copy link
Copy Markdown
Collaborator

@atreyamaj atreyamaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me, looks really cool and matches the background as well! Awaiting reviews from @saum7800 @suhanichawla

@suhanichawla suhanichawla self-requested a review April 16, 2021 03:45
@suhanichawla
Copy link
Copy Markdown
Member

suhanichawla commented Apr 16, 2021

Mic looks really cool! Working perfectly! 👍
Just want to confirm if you have implemented interrupting speak positions as well

@n-maido
Copy link
Copy Markdown
Member Author

n-maido commented Apr 16, 2021

Hello, I also pushed some commits that address issue #54 !

  • Allow user to interrupt the speak positions by pressing the escape button
interrupt.mp4

@n-maido
Copy link
Copy Markdown
Member Author

n-maido commented Apr 16, 2021

Mic looks really cool!
Just want to confirm if you have implemented interrupting speak positions as well

Yup!

@suhanichawla
Copy link
Copy Markdown
Member

Awesome, working perfectly! ⭐

@suhanichawla suhanichawla merged commit b629c7c into MLH-Fellowship:main Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon to denote that voice input is active. Keyboard Interrupt to stop speak positions

3 participants