Allow disabling DarkNet usage that breaks app under Wine#379
Merged
Conversation
…t function INSTEAD of darknet allow avoid darknet entirely
…rective more clear on why it's there
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that DarkNet uses undocumented windows functions that Wine doesn't implement/export. This prevents users from running this application in a Wine environment.
This PR adds a setting that allows disabling that part of DarkNet, thus enabling the app to run under Wine.
If you have strong feelings about extension methods, I can change it to a static call, or something.
SkipDarkNetas the key isn't entirely accurate due to not preventing use of theDarkNet.Instance.SetCurrentProcessTheme. I can skip that call too, for the sake of consistency, if preferred.