Skip to content

Added speed improvement to retrieving web Table data rows #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tom-made merged 2 commits into from
Jan 3, 2023
Merged

Added speed improvement to retrieving web Table data rows #195

tom-made merged 2 commits into from
Jan 3, 2023

Conversation

@jamesmcroft
Copy link
Member

@jamesmcroft jamesmcroft commented Jan 3, 2023

Resolves #194

Changes have been made to introduce a new By locator for retrieving table data rows based on whether a tr element is located which contains td elements.

PR checklist

  • Have Legerity sample tests been added or updated, run locally, and all pass
  • Have added or updated support for platform specific element wrappers been reflected in the Page Object Generator
  • Have code styling rules been run on all new source file changes
  • Have relevant articles in the docs been added or updated for all new source file changes
  • Have major breaking changes been made and are documented

Other information

@jamesmcroft jamesmcroft requested a review from a team as a code owner January 3, 2023 08:48
@jamesmcroft jamesmcroft linked an issue Jan 3, 2023 that may be closed by this pull request
[Bug] Improve speed of retrieving web Table data rows #194
Closed
@tom-made tom-made merged commit e2f7d4b into main Jan 3, 2023
@tom-made tom-made deleted the 194-table-data-row-improvements branch January 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-made tom-made tom-made approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Improve speed of retrieving web Table data rows

3 participants

@jamesmcroft @tom-made