Skip to content

Adding UIA accessible objects for Label, Button, Splitter, GroupBox, PictureBox, CheckBox and ListView controls#1

Merged
M-Lipin merged 2 commits intodev/v-milipi/Issue_2164_Narrator_caps_navigationfrom
dev/v-alebe/Issue_2164_Narrator_caps_navigation
May 4, 2020
Merged

Adding UIA accessible objects for Label, Button, Splitter, GroupBox, PictureBox, CheckBox and ListView controls#1
M-Lipin merged 2 commits intodev/v-milipi/Issue_2164_Narrator_caps_navigationfrom
dev/v-alebe/Issue_2164_Narrator_caps_navigation

Conversation

@Ryuugamine
Copy link
Collaborator

@Ryuugamine Ryuugamine commented Apr 14, 2020 •
edited by M-Lipin
Loading

Fixes dotnet#2164

Proposed changes

Adding UIA accessible objects for:
[x] Button control
[x] TextBox control
[x] Label
[x] Splitter
[x] GroupBox
[x] PictureBox
[x] Checkbox
[x] ListView

M-Lipin
M-Lipin reviewed Apr 15, 2020
View reviewed changes
M-Lipin
M-Lipin requested changes Apr 15, 2020
View reviewed changes
Copy link
Owner

@M-Lipin M-Lipin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thanks! Please address the points and also move ButtonAccessibleObject and TextBoxAccessibleObject to separate files.

M-Lipin
M-Lipin reviewed Apr 17, 2020
View reviewed changes
M-Lipin
M-Lipin reviewed Apr 17, 2020
View reviewed changes
M-Lipin
M-Lipin reviewed Apr 17, 2020
View reviewed changes
M-Lipin
M-Lipin reviewed Apr 17, 2020
View reviewed changes
M-Lipin
M-Lipin reviewed Apr 17, 2020
View reviewed changes
M-Lipin
M-Lipin reviewed Apr 17, 2020
View reviewed changes
@M-Lipin
Copy link
Owner

M-Lipin commented Apr 17, 2020

Please also update PR name and description to list all controls that are already finished. In the PR description, you can also use "[x]" and "[ ]" to put the full checked list of controls to be reworked.

M-Lipin
M-Lipin reviewed Apr 24, 2020
View reviewed changes
Tanya-Solyanik
Tanya-Solyanik reviewed Apr 30, 2020
View reviewed changes
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewItemAccessibleObject.cs Outdated
Copy link

@Tanya-Solyanik Tanya-Solyanik Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra line

Tanya-Solyanik
Tanya-Solyanik reviewed Apr 30, 2020
View reviewed changes
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated
Copy link

@Tanya-Solyanik Tanya-Solyanik Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like only ListViewItems can be children of the ListView. However Groups are displayed in the ListView Hierarchy as well. Should we add support for them?

Copy link
Owner

@M-Lipin M-Lipin May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks, we should. I'll add it.

@M-Lipin M-Lipin changed the title Added accessible objects for Button and TextBox controls Adding UIA accessible objects for Label, Button, Splitter, GroupBox, PictureBox, CheckBox and ListView controls May 4, 2020
@M-Lipin M-Lipin force-pushed the dev/v-alebe/Issue_2164_Narrator_caps_navigation branch from a2a1457 to 913d402 Compare May 4, 2020 17:29
@M-Lipin M-Lipin merged commit 4fbc782 into dev/v-milipi/Issue_2164_Narrator_caps_navigation May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M-Lipin M-Lipin M-Lipin requested changes

+1 more reviewer

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ryuugamine @M-Lipin @Tanya-Solyanik @AleksandrBeliaev