Fix FFProbe keywords as String#68
Merged
qwerty287 merged 1 commit intoLycheeOrg:masterfrom Apr 29, 2023
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
I think it would be good to have an end-to-end test for this, i.e. add a video file that has these keywords and then parse the file (also in addition to the current tests). Or is this something specific for a version of ffprobe and not for a file? |
Author
|
@qwerty287 I don't think it comes from a specific file as I have used such files for a long time and it only recently stopped working. The only thing that has changed is Lychee and probably ffprobe. |
qwerty287
approved these changes
Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffprobeversion 4.4.2 returns a string for tags likecom.apple.quicktime.keywords:example:
If the value is a string, this patch splits on a comma multiple keywords.