Fix Exif extraction logic when using ImageMagick#65
Merged
qwerty287 merged 2 commits intoLycheeOrg:masterfrom Apr 11, 2023
wladif:master
Merged
Fix Exif extraction logic when using ImageMagick#65qwerty287 merged 2 commits intoLycheeOrg:masterfrom wladif:master
qwerty287 merged 2 commits intoLycheeOrg:masterfrom
wladif:master
Conversation
added 2 commits
April 10, 2023 20:53
This PR removes the mapping of the file's creation date to the Exif::CREATION_DATE. This is done in order to align it to the logic of the other two tools used for Exif extraction: Exiftool & Native. None of this two will fill in the Exif::CREATION_DATE with the file's creation time. This is part of the #1729 enhancement for which we need to be able to figure out if the file has a creation time as exif field or not. We can't do this currently with Lychee & ImageMagick.
|
Kudos, SonarCloud Quality Gate passed!
|
qwerty287
approved these changes
Apr 10, 2023
qwerty287
left a comment
There was a problem hiding this comment.
So the date:create field is the file creation time?
Author
Yes, the field contains the same value as the one returned by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the mapping of the file's creation date to the Exif::CREATION_DATE. This is done in order to align it to the logic of the other two tools used for Exif extraction: Exiftool & Native. None of this two will fill in the Exif::CREATION_DATE with the file's creation time.
This is part of the #1729 enhancement for which we need to be able to figure out if the file has a creation time as exif field or not. We can't do this currently with Lychee & ImageMagick.