Skip to content

Fix #4117 - Fix going back to selected tag page.#4155

Merged
ildyria merged 1 commit intomasterfrom
fix-4117
Mar 8, 2026
Merged

Fix #4117 - Fix going back to selected tag page.#4155
ildyria merged 1 commit intomasterfrom
fix-4117

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Mar 8, 2026 •
edited by coderabbitai bot
Loading

  • fix contact link displayed in menu when not logged in.

Summary by CodeRabbit

  • Bug Fixes
    • Restricted messages menu visibility to require admin access in addition to existing permissions.
    • Updated navigation logic in the gallery tag panel to properly respect application state.

@ildyria ildyria requested a review from a team as a code owner March 8, 2026 11:14
@coderabbitai
Copy link

coderabbitai bot commented Mar 8, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 12213ea8-9caa-42b7-b6ee-63149aa5a613

📥 Commits

Reviewing files that changed from the base of the PR and between c1e0cc9 and 778c79a.

📒 Files selected for processing (2)
  • resources/js/composables/contextMenus/leftMenu.ts
  • resources/js/views/gallery-panels/Tag.vue
📝 Walkthrough

Walkthrough

Two visibility and control flow adjustments across UI components: strengthened access control for the left menu messages item by adding an admin rights check, and modified the gallery panel back-navigation logic to reference the photo store state instead of local component state.

Changes

Cohort / File(s) Summary
Left Menu Access Control
resources/js/composables/contextMenus/leftMenu.ts		 Added admin rights validation (canSeeAdmin.value) to existing contact enabled check for messages menu item visibility.
Gallery Panel Navigation
resources/js/views/gallery-panels/Tag.vue		 Modified goBack() condition to check photoStore.photoId instead of local photoId prop, changing the state reference for navigation logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through menus bright,
Where admin gates now hold the light,
And photo paths find newer ways,
Through store-bound state and cleaner days! ✨

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ildyria ildyria merged commit a51f487 into master Mar 8, 2026
45 checks passed
@ildyria ildyria deleted the fix-4117 branch March 8, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ildyria