Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

database/migrations/2026_01_19_193315_refactor_photo_avoid_duplicates.php (1)

19-21: Inconsistent indentation: spaces used instead of tabs.

Lines 19–21 and 38–84 use spaces for indentation while the rest of the file uses tabs. As per coding guidelines, run vendor/bin/php-cs-fixer fix before committing to ensure consistent formatting.

Also applies to: 38-44

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

database/migrations/2026_01_19_193315_refactor_photo_avoid_duplicates.php (1)

56-73: ⚠️ Potential issue | 🟠 Major

Do not suppress all QueryExceptions in inner transactions.

At Line 56 and Line 70, every QueryException is ignored. That can hide real DB errors (not just duplicate-link collisions), then Lines 78-83 still delete rows, which can lose associations/data. Please only swallow duplicate-key violations and rethrow everything else.

Suggested fix

                 } catch (QueryException $e) {
-                    // If this crashes this means that the link already exists between the photo and the album.
-                    // We ignore it.
-                    // So we rollback this part
                     DB::rollBack();
+                    $sql_state = (string) ($e->errorInfo[0] ?? $e->getCode());
+                    $driver_code = $e->errorInfo[1] ?? null;
+                    $is_duplicate = $sql_state === '23505'
+                        || ($sql_state === '23000' && in_array($driver_code, [1062, 19], true));
+                    if (!$is_duplicate) {
+                        throw $e;
+                    }
                 } catch (\Exception $e) {
                     throw $e;
                 }
@@
                 } catch (QueryException $e) {
-                    // Same shit as above. :)
                     DB::rollBack();
+                    $sql_state = (string) ($e->errorInfo[0] ?? $e->getCode());
+                    $driver_code = $e->errorInfo[1] ?? null;
+                    $is_duplicate = $sql_state === '23505'
+                        || ($sql_state === '23000' && in_array($driver_code, [1062, 19], true));
+                    if (!$is_duplicate) {
+                        throw $e;
+                    }
                 } catch (\Exception $e) {
                     throw $e;
                 }

In Laravel (QueryException/PDO), what SQLSTATE and driver error codes indicate duplicate-key violations for MySQL/MariaDB, PostgreSQL, and SQLite?

As per coding guidelines: "Use in_array() with true as the third parameter".

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

database/migrations/2026_01_19_193315_refactor_photo_avoid_duplicates.php (2)

56-63: ⚠️ Potential issue | 🟠 Major

Add SQLSTATE filtering to only suppress duplicate-key violations.

Catching all QueryException errors without checking the error code will silently swallow connection errors, syntax errors, timeouts, and other real failures. Filter by SQLSTATE code to only suppress duplicate-key violations ('23000' for MySQL/SQLite, '23505' for PostgreSQL).

Proposed fix

             } catch (QueryException $e) {
                 // If this crashes this means that the link already exists between the photo and the album.
                 // We ignore it.
                 // So we rollback this part
                 DB::rollBack();
+                $sql_state = $e->getCode();
+                if (!in_array($sql_state, ['23000', '23505'], true)) {
+                    throw $e;
+                }
             } catch (\Exception $e) {
                 throw $e;
             }

---

70-75: ⚠️ Potential issue | 🟠 Major

Same issue: Add SQLSTATE filtering here as well.

This catch block has the same problem—it will silently suppress all query exceptions, not just duplicate-key violations.

Proposed fix

             } catch (QueryException $e) {
                 // Same shit as above. :)
                 DB::rollBack();
+                $sql_state = $e->getCode();
+                if (!in_array($sql_state, ['23000', '23505'], true)) {
+                    throw $e;
+                }
             } catch (\Exception $e) {
                 throw $e;
             }

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro