Remove endpoint to fetch all data in one go for an album#4124
Remove endpoint to fetch all data in one go for an album#4124
Conversation
📝 WalkthroughWalkthroughThis PR removes the album retrieval API endpoint and its related resource classes. The GET /Album route, AlbumController::get(), and four album resource classes (AbstractAlbumResource, AlbumResource, SmartAlbumResource, TagAlbumResource) were deleted; associated tests were adjusted or removed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/Feature_v2/Album/AlbumTest.php (1)
25-32: Consider renaming the test method for clarity.The method name
testGetwas appropriate when testing the removed/AlbumGET endpoint, but now that it tests theAlbum::headendpoint's validation, a more descriptive name liketestHeadRequiresAlbumIdwould better reflect its purpose.✨ Optional rename for improved readability
- public function testGet(): void + public function testHeadRequiresAlbumId(): void { $response = $this->getJson('Album::head'); $this->assertUnprocessable($response); $response->assertJson([ 'message' => 'The album id field is required.', ]); }
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tests/Feature_v2/Album/AlbumTest.phptests/Feature_v2/PaginationIntegrationTest.php
💤 Files with no reviewable changes (1)
- tests/Feature_v2/PaginationIntegrationTest.php
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit