lang/ja/gallery.php (1)

121-122: New translation values are in English, not Japanese.

The newly added keys (apply_renamer, watermark, apply_renamer_all) have English values in the Japanese locale file. While the file does have a mix of translated and untranslated strings, consider providing Japanese translations for consistency with other translated entries in this file.

Suggested translations (please verify with a native speaker):

• 'apply_renamer' => 'リネーマールールを適用', (Apply Renamer Rules)
• 'watermark' => 'ウォーターマーク', (Watermark)
• 'apply_renamer' => 'リネーマーを適用', (Apply Renamer - in menus)
• 'apply_renamer_all' => '選択項目にリネーマーを適用', (Apply Renamer to Selected)

Also applies to: 260-261

lang/zh_CN/gallery.php (2)

121-122: Missing Chinese translations for new keys.

These entries are in English but should be translated to Chinese for the zh_CN locale. Suggested translations:

-            'apply_renamer' => 'Apply Renamer Rules',
-            'watermark' => 'Watermark',
+            'apply_renamer' => '应用重命名规则',
+            'watermark' => '水印',

---

260-261: Missing Chinese translations for menu entries.

These menu items should also be translated for consistency with the surrounding Chinese entries:

-        'apply_renamer' => 'Apply Renamer',
-        'apply_renamer_all' => 'Apply Renamer to Selected',
+        'apply_renamer' => '应用重命名',
+        'apply_renamer_all' => '应用重命名到所选',

lang/zh_TW/gallery.php (2)

121-122: Missing Traditional Chinese translations.

These new entries contain English text instead of Traditional Chinese translations. Other strings in this locale file are properly translated (e.g., '釘選', '列表檢視', '公開但隱藏'). Consider translating these for consistency:

• 'apply_renamer' => '套用重新命名規則',
• 'watermark' => '浮水印',

---

260-261: Missing Traditional Chinese translations for menu items.

Same issue as above — these menu entries use English text. Consider:

• 'apply_renamer' => '套用重新命名',
• 'apply_renamer_all' => '套用重新命名至所選項目',

lang/hu/dialogs.php (1)

264-288: Localize the new Hungarian dialog strings (currently English).

Lines 265-287 introduce new hu locale entries, but the values are English. This works functionally, but it regresses locale consistency in Hungarian UI surfaces. Please localize these new keys (or explicitly document English fallback policy for this locale).

tests/Feature_v2/RenamerRules/RenamerPreviewTest.php (1)

123-147: Consider cleanup of dynamically created rules.

The testPreviewNoChanges and testPreviewRuleIdsFiltering tests create additional RenamerRule records within the test method. While the DatabaseTransactions trait should roll back these changes, it's worth verifying that the RequiresEmptyRenamerRules trait properly handles cleanup.

If cleanup becomes an issue, consider storing the rule ID and explicitly deleting it in the test, or relying on the trait's teardown. Current implementation should work given the transaction rollback.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

resources/js/components/forms/album/ApplyRenamerDialog.vue (1)

163-213: ⚠️ Potential issue | 🟡 Minor

Handle API failures and always clear loading state.

loadRules(), loadPreview(), and applyRules() still have no failure path; this can leave loading UI stuck and gives no error feedback.

🛠️ Suggested fix pattern

 function loadRules() {
 	is_loading_rules.value = true;
 	RenamerService.list().then((response) => {
 		rules.value = response.data;
 		selected_rule_ids.value = rules.value.map((r) => r.id);
-		is_loading_rules.value = false;
+	}).catch(() => {
+		toast.add({ severity: "error", summary: trans("toasts.error"), life: 5000 });
+	}).finally(() => {
+		is_loading_rules.value = false;
 	});
 }

 function loadPreview() {
 	is_loading_preview.value = true;
 	step.value = "preview";
 	RenamerService.preview({ ... }).then((response) => {
 		preview_items.value = response.data;
-		is_loading_preview.value = false;
+	}).catch(() => {
+		toast.add({ severity: "error", summary: trans("toasts.error"), life: 5000 });
+	}).finally(() => {
+		is_loading_preview.value = false;
 	});
 }

 function applyRules() {
 	...
 	RenamerService.rename(data).then(() => {
 		...
+	}).catch(() => {
+		toast.add({ severity: "error", summary: trans("toasts.error"), life: 5000 });
 	});
 }

app/Actions/Renamer/PreviewPhotos.php (1)

49-55: Avoid materializing all descendant album IDs in memory.

For large trees, pluck('id') here can become expensive. Prefer constraining the whereHas('albums', ...) subquery directly by _lft/_rgt.

♻️ Suggested refactor

-				$descendant_ids = Album::query()
-					->where('_lft', '>=', $parent->_lft)
-					->where('_rgt', '<=', $parent->_rgt)
-					->pluck('id');
-				$query->whereHas('albums', function ($q) use ($descendant_ids): void {
-					$q->whereIn('albums.id', $descendant_ids);
+				$query->whereHas('albums', function ($q) use ($parent): void {
+					$q->where('albums._lft', '>=', $parent->_lft)
+						->where('albums._rgt', '<=', $parent->_rgt);
 				});

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

app/Actions/Renamer/RenameAlbums.php (1)

45-45: Fix the inline comment wording for albums.

Line 45 mentions “photo titles”, but this block updates album titles.

✏️ Suggested edit

-				// Make a batch update to update all photo titles at once
+				// Make a batch update to update all album titles at once

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro