Skip to content

Fix documentation url#4112

Merged
ildyria merged 1 commit intomasterfrom
fix-docs-url
Feb 24, 2026
Merged

Fix documentation url#4112
ildyria merged 1 commit intomasterfrom
fix-docs-url

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Feb 24, 2026 •
edited by coderabbitai bot
Loading

Fixes #4096

Summary by CodeRabbit

  • Bug Fixes
    • Improved URL handling for the API documentation link in the menu to ensure proper navigation.

@ildyria ildyria requested a review from a team as a code owner February 24, 2026 10:46
@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The Lychee API submenu item URL changed from a relative path ("/docs/api") to an absolute URL using Constants.BASE_URL + "/docs/api", ensuring consistent navigation regardless of the application context.

Changes

Cohort / File(s) Summary
URL Path Conversion
resources/js/composables/contextMenus/leftMenu.ts		 Changed Lychee API submenu URL from relative path to absolute URL using BASE_URL constant.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path once relative, now stands tall and true,
With BASE_URL as anchor, the API shines through,
One small change, one big leap for consistency's sake,
Our docs will be found, no matter the take! 📚✨

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot requested changes Feb 24, 2026
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3d57e6 and 7ae1e15.

📒 Files selected for processing (1)
  • resources/js/composables/contextMenus/leftMenu.ts

@codecov
Copy link

codecov bot commented Feb 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (d3d57e6) to head (7ae1e15).
⚠️ Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit f9523a4 into master Feb 24, 2026
44 checks passed
@ildyria ildyria deleted the fix-docs-url branch February 24, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Documentation API" link is wrong when Lychee is instaled in a sub-directory

1 participant

@ildyria