Skip to content

Fix zip first install#4092

Merged
ildyria merged 1 commit intomasterfrom
fix-zip-first-install
Feb 15, 2026
Merged

Fix zip first install#4092
ildyria merged 1 commit intomasterfrom
fix-zip-first-install

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Feb 15, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • LDAP PHP extension has been added as a required dependency for system installation and deployment.

  • Bug Fixes

    • Improved application resilience with enhanced error handling during configuration initialization and middleware operations. The system now gracefully manages scenarios where required database tables may not yet exist, preventing potential request disruptions.

@ildyria ildyria requested a review from a team as a code owner February 15, 2026 19:34
@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Three changes strengthen application initialization and configuration handling: adding LDAP PHP extension to requirements, and implementing table existence guards in two middleware classes to prevent errors when the configs table is unavailable.

Changes

Cohort / File(s) Summary
Dependency Requirements
app/Actions/InstallUpdate/DefaultConfig.php		 Added ldap PHP extension to the list of required PHP extensions for Laravel dependencies.
Middleware Table Existence Guards
app/Http/Middleware/ResolveConfigs.php, app/Http/Middleware/ResolveVerify.php		 Introduced Schema::hasTable() checks wrapped in try-catch blocks to guard configuration resolution logic against missing or inaccessible configs table, allowing graceful early returns to next middleware on failure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Whiskers twitching with delight,
LDAP now required, configured right,
Guard the tables, check before we leap,
Safe middleware where configs sleep! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 15, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.18%. Comparing base (8fd6481) to head (9131245).
⚠️ Report is 2 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 9f72146 into master Feb 15, 2026
44 checks passed
@ildyria ildyria deleted the fix-zip-first-install branch February 15, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ildyria