Skip to content

Fix event propagation#4044

Merged
ildyria merged 1 commit intomasterfrom
fix-right-click-album-grid
Jan 29, 2026
Merged

Fix event propagation#4044
ildyria merged 1 commit intomasterfrom
fix-right-click-album-grid

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Jan 29, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Streamlined album component event handling by consolidating event propagation logic.
    • Removed the isInteractive prop from album components; interactions are now enabled by default.
    • Standardized event payload signatures across album-related components for improved consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@ildyria ildyria requested a review from a team as a code owner January 29, 2026 11:27
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR introduces a new album event propagation composable and refactors the album component event system. Album components now emit album ids instead of full album objects, function signatures are reordered to a consistent (event, id) pattern, the isInteractive prop is removed, and event handling is consolidated through the new usePropagateAlbumEvents composable.

Changes

Cohort / File(s) Summary
Album component event refactoring
resources/js/components/gallery/albumModule/AlbumListItem.vue, resources/js/components/gallery/albumModule/AlbumListView.vue, resources/js/components/gallery/albumModule/AlbumThumbPanel.vue, resources/js/components/gallery/albumModule/AlbumThumbPanelList.vue		 Replaced album object emissions with id strings in clicked/contexted events; reordered signatures from (id, event) to (event, id); removed isInteractive prop; integrated usePropagateAlbumEvents composable for unified event propagation.
New propagation composable
resources/js/composables/album/propagateEvents.ts		 Added new composable exporting usePropagateAlbumEvents function to handle centralized album event emission with propagateClicked and propagateContexted helpers.
Selection and context menu handler signatures
resources/js/composables/contextMenus/contextMenu.ts, resources/js/composables/selections/selections.ts		 Updated albumMenuOpen and albumSelect function signatures from (id, event) to (event, id) to align with new event propagation pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 From objects to ids, a cleaner way,
Events now flow through composables today!
Signatures aligned, no more isInteractive—
Album propagation is now interactive! ✨

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ildyria ildyria merged commit e5278d6 into master Jan 29, 2026
44 checks passed
@ildyria ildyria deleted the fix-right-click-album-grid branch January 29, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ildyria