Patch Windows hipBLAS dll loading#470
Merged
LostRuins merged 1 commit intoLostRuins:concedo_experimentalfrom Oct 10, 2023
Merged
Patch Windows hipBLAS dll loading#470LostRuins merged 1 commit intoLostRuins:concedo_experimentalfrom
LostRuins merged 1 commit intoLostRuins:concedo_experimentalfrom
Conversation
…low use of hip SDK (if installed) dlls on windows * If the rocm/hip sdk is installed on windows, then include the sdk as a potential location to load the hipBlas/rocBlas .dlls from. This allows running koboldcpp.py directly with python after building work on windows without having to build the .exe and run that or copy .dlls around.
LostRuins
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds system's HIP_PATH/bin folder to the DLL directories that get loaded so rocBLAS/hip files don't need to be in the KoboldCPP folder