ios26 fixes#573
Merged
Merged
Conversation
ps2
commented
Oct 20, 2025
Collaborator
- DIsabled actions buttons look disabled
- Information views do not auto-dismiss
- Saving values in warning ranges works again
marionbarker
approved these changes
Oct 21, 2025
Contributor
There was a problem hiding this comment.
Approve based on test. See LoopKit/Loop#2371 (comment) which indicates failures described in #2360 are fixed.
I don't have an example where the inactive button was not grey and where information views auto-dismissed, so I can't demonstrate these are fixed. But willing to approve and accept this change without that test.
I did test examples for all 3 fixes as reported in later comments under Loop PR 2371.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.