Merged
Conversation
CheatCod
requested changes
Feb 25, 2023
Member
CheatCod
left a comment
There was a problem hiding this comment.
Some test cases would be nice :)
Member
|
There is a bug involved in the old unzip logic, where the function does a diff of the destination dir before and after the unzip. So if the unzip overwrote some files, the file paths are not returned. The desired behavior will be to get the content of the archive (listing the files in the temp dir) |
CheatCod
requested changes
Feb 28, 2023
| let archive = unrar::Archive::new(file.to_str().ok_or_else(|| eyre!("Non-unicode character in file name {}", file.display()))?.to_string()); | ||
| archive | ||
| .extract_to(temp_dest.to_str().ok_or_else(|| eyre!("Non-unicode character in file name {}", temp_dest.display()))?.to_string()) | ||
| .map_err(|_| eyre!("Failed to decompress file {}", file.display()))? |
| .extract_to(temp_dest.to_str().ok_or_else(|| eyre!("Non-unicode character in file name {}", temp_dest.display()))?.to_string()) | ||
| .map_err(|_| eyre!("Failed to decompress file {}", file.display()))? | ||
| .process() | ||
| .map_err(|_| eyre!("Failed to decompress file {}", file.display()))?; |
Contributor
Author
There was a problem hiding this comment.
note: the following trait bounds were not satisfied:
UnrarError<Vec<unrar::archive::Entry>>: eyre::context::ext::StdError
They didn't make their error type good I guess
CheatCod
approved these changes
Mar 8, 2023
Member
CheatCod
left a comment
There was a problem hiding this comment.
Please install clippy and watch out for minor details such as unused deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ZIP
Type of change
Note: make sure your files are formatted with rust-analyzer