Merged
Conversation
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Arcslogger
requested changes
Mar 12, 2023
Member
There was a problem hiding this comment.
Some horizontal and vertical alignment issues? Specifically:
- left margin is less than right margin, is it because of the scroll bar?
- Looks like the icon + text is a little too high and it looks a bit wonky visually (tho this is a smol nitpick)
Left is code, right is figma
Ynng
requested changes
Mar 13, 2023
Member
|
Please add the |
Ynng
approved these changes
Mar 13, 2023
Member
Ynng
left a comment
There was a problem hiding this comment.
works great! let's get this pr merged!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added no instance state for left bar and home page