#157 Unify errors into a single component#184
Merged
kevinzhang03 merged 7 commits into0.4.3from Mar 4, 2023
Merged
Conversation
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ynng
requested changes
Mar 4, 2023
Member
Ynng
left a comment
There was a problem hiding this comment.
looks good! just please use a utility to merge the tailwind classnames
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#157
Created a new component
ErrorGraphicthat is responsible for rendering the UI whenever there is an error forGameConsoleandFileViewer. It is designed so that it can be used with other components as well as it takes props to display the different parts of the error UI.Also added a dark highlight colour on whichever file you have open to make it easier to tell which one you're on. Also added proper pluralization when listing how many files are selected/in the clipboard.
How Has This Been Tested?
The current errors are rendered by checking for conditions to see if there is an error. I "created" the errors by modifying the conditions so that the component would go to render
ErrorGraphic. It looks identical to how it was before, except now that it is done with theErrorGraphiccomponent instead.