Skip to content

left nav tweaks#167

Merged
Ynng merged 5 commits into0.4.2from
leftnavTweaks
Feb 21, 2023
Merged

left nav tweaks#167
Ynng merged 5 commits into0.4.2from
leftnavTweaks

Conversation

@Arcslogger
Copy link
Member

@Arcslogger Arcslogger commented Feb 20, 2023

attempts to fix the floaty feeling the nav currently has:

  • reduced x-padding
  • thinner width to mitigate padding
  • thinner font weight
  • New Instance... doesn't look like it's disabled

also cleaned up some broken tailwind classes and unused imports


screenshots:

(note: all screenshots are taken on a 1440p 27" monitor running macos)

before After
image image

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 1697c9a
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63f4380f6e324c0008f9029e
😎 Deploy Preview https://deploy-preview-167--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Arcslogger
Copy link
Member Author

note: if things still feel strange then we might want to take a look at changing satoshi to something else. The more I work with it the more I realize it has kinda shit legibility at small font sizes

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 1697c9a
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/63f4380f74ba8600089ec1aa
😎 Deploy Preview https://deploy-preview-167--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can we also make everything larger, or would that take too long

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry meant to approve

Copy link
Contributor

@NicholasLin718 NicholasLin718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizing issue:
image

This is caused by the Menu button inside UserMenu using w-full in order to give the text inside the button a width to truncate with. However, the core settings icon is not included within the Menu button's w-full, so it will get cut off when a longer username is used.

@Ynng Ynng merged commit 1c90840 into 0.4.2 Feb 21, 2023
@Ynng Ynng deleted the leftnavTweaks branch February 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants