Merged
Conversation
…, and new styling
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was
linked to
issues
Feb 14, 2023
Closed
Ynng
requested changes
Feb 14, 2023
Ynng
requested changes
Feb 16, 2023
Member
Ynng
left a comment
There was a problem hiding this comment.
left nav scrolling is still broken ish,
the buttons in the left nav is missing the blue glowing border on tab
and this:
Ynng
requested changes
Feb 16, 2023
Member
Ynng
left a comment
There was a problem hiding this comment.
- The "power" button doesn't have keybaord focus border
- the "power" button isn't really a square?
- Scrolling behavior of the left nav is still not perfect
- When I change instant, the tab jumps back to /overview, can we keep the current tab
Ynng
requested changes
Feb 17, 2023
Member
Ynng
left a comment
There was a problem hiding this comment.
- The restart button does not have tooltip
- The spacing is different between the restart <-> power button, and user dropdown <-> gear icon
This was referenced Feb 18, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IconButtonused for core setting and power on/off of a selected instance/dashboard/{tab_name}. The new default isdashboard/overview*Currently, the navbar and user login dropdown have hardcoded widths and will require investigation to determine how we can truncate the username whilst using dynamic width.