Update ToastContainer to set icons in toasts based on toast type#150
Merged
kevinzhang03 merged 2 commits into0.4.2from Feb 12, 2023
Merged
Update ToastContainer to set icons in toasts based on toast type#150kevinzhang03 merged 2 commits into0.4.2from
kevinzhang03 merged 2 commits into0.4.2from
Conversation
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
|
Just for the record: the branch was named incorrectly. It should have been |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a
renderIconfunction that returns the appropriate toast type for the correspondingIconProps.typepassed in. Now, the icon prop in theToastContainercomponent uses therenderIconfunction.There is no success toast however, since
leveldoes not accept'Success'. The default toast type is the info toast.#110