Added get_path method to Run so the path can be actually accessed.#312
Merged
CryZe merged 2 commits intoLiveSplit:masterfrom Mar 12, 2020
Ynscription:accessPathFromRun
Merged
Added get_path method to Run so the path can be actually accessed.#312CryZe merged 2 commits intoLiveSplit:masterfrom Ynscription:accessPathFromRun
CryZe merged 2 commits intoLiveSplit:masterfrom
Ynscription:accessPathFromRun
Conversation
CryZe
requested changes
Mar 12, 2020
Collaborator
CryZe
left a comment
There was a problem hiding this comment.
Also there's a formatting mismatch. Probably a tab or some weird whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aded a get_path method to Run so the path can be accessed for saving, as I asume it was intended to be.
The Run struct contains an Option to store the path to the save file it was loaded from.
This comes in really handy when saving, as the path can be simply read from the path.
However, the path attribute of Run was private and inaccessible in any way, making it unusable.
Now the path should be easily accessible.