Implement Columns for the Splits Component#149
Merged
CryZe merged 12 commits intoLiveSplit:masterfrom Nov 13, 2018
Merged
Conversation
This implements initial support for columns for the splits component. The columns differ a bit from the original LiveSplit in that they don't have a single type. Instead they define a value they start out with and a value they get updated with. This allows for some interesting combinations that were not possible before.
Collaborator
Author
|
There's a few things that are still marked as TODO in there. So I'll either implement them before merging this or implement them in a followup PR. |
The C API was accidentally still assuming the time and delta values exist.
The Timing Method and Comparison can now be overriden on a per column basis.
There's also the toggle to show / hide them above the splits.
They contain the split column changes now.
Not every combination is supported yet, such as contextual split times and segment times.
wooferzfg
approved these changes
Nov 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements initial support for columns for the splits component. The columns differ a bit from the original LiveSplit in that they don't have a single type. Instead they define a value they start out with and
a value they get updated with. This allows for some interesting combinations that were not possible before.