Conversation
The feature is activated by default.
glacials
approved these changes
Sep 27, 2018
glacials
left a comment
There was a problem hiding this comment.
Out of curiosity, what's the reason you want to delay releasing this into LiveSplit One until more splits in the wild are shrunk?
|
|
||
| [features] | ||
| default = ["image-shrinking"] | ||
| image-shrinking = ["image/webp", "image/pnm", "image/ico", "image/jpeg", "image/gif_codec", "image/tiff", "image/tga", "image/bmp", "image/hdr"] |
Collaborator
Author
There was a problem hiding this comment.
image/png is always compiled in, as we already reencode Llanfair's headerless bitmaps to png. So these are only those that are conditionally activated.
Collaborator
Author
|
It's fairly slow opening splits that have large images in them, so I'd prefer reducing the amount of yet to be resized images that are around. I think natively compiled it does the conversion a bit faster, and we want to do it there as soon as possible anyway, so I'd rather wait a bit. |
wasm has its own libm now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary eventually. However it also comes with a few downsides such as longer compile times, larger binary size and longer parsing times of splits due to the shrinking. This introduces the
image-shrinkingfeature that allows you to choose whether you want to compile this in. It is activated by default. The plan is to introduce this to the original LiveSplit and Splits I/O before this lands in LiveSplit One, so that we can reduce the amount of actively used splits in the wild that still need to be shrunk once LiveSplit One gets the feature.Closes #47