Skip to content

Fix unreachable code when parsing Font name from original LiveSplit #486

@kadiwa4

Description

@kadiwa4

In fn layout::parser::font, there is a long list of else ifs, including the following two:

} else if token.eq_ignore_ascii_case("normal") {
    weight = FontWeight::Normal;
}

and

} else if token.eq_ignore_ascii_case("normal") {
    stretch = FontStretch::Normal;
}

which both have the same condition, so the second one cannot be reached (source code).
I don't know what the intended behavior would be.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThere is a bug.suitable for contributionsThe issue is suitable those who are contributing to livesplit-core.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions