-
Notifications
You must be signed in to change notification settings - Fork 72
Switch from chrono to the time crate #457
Copy link
Copy link
Closed
Labels
code qualityAffects the quality of the code.Affects the quality of the code.enhancementAn improvement for livesplit-core.An improvement for livesplit-core.suitable for contributionsThe issue is suitable those who are contributing to livesplit-core.The issue is suitable those who are contributing to livesplit-core.
Metadata
Metadata
Assignees
Labels
code qualityAffects the quality of the code.Affects the quality of the code.enhancementAn improvement for livesplit-core.An improvement for livesplit-core.suitable for contributionsThe issue is suitable those who are contributing to livesplit-core.The issue is suitable those who are contributing to livesplit-core.
The
timecrate used to be fairly simplistic and thus mostly unusable for our purposes. Sochronowas built on top of it. Thetimecrate since then however got a new maintainer and it's more lightweight thanchronoand fits what we usechronofor pretty well.chronoseems to be pretty unmaintained for a while now and there also seems to be a vulnerability in it (race condition in the underlying libc's setenv). So yeah it probably makes sense to look into this.