-
Notifications
You must be signed in to change notification settings - Fork 72
Use perceptual hashing algorithm for the rendering tests #287
Copy link
Copy link
Closed
Labels
ciAffects the Continuous Integration.Affects the Continuous Integration.code qualityAffects the quality of the code.Affects the quality of the code.renderingThe issue or pull request is affecting the rendering.The issue or pull request is affecting the rendering.suitable for contributionsThe issue is suitable those who are contributing to livesplit-core.The issue is suitable those who are contributing to livesplit-core.
Metadata
Metadata
Assignees
Labels
ciAffects the Continuous Integration.Affects the Continuous Integration.code qualityAffects the quality of the code.Affects the quality of the code.renderingThe issue or pull request is affecting the rendering.The issue or pull request is affecting the rendering.suitable for contributionsThe issue is suitable those who are contributing to livesplit-core.The issue is suitable those who are contributing to livesplit-core.
Looks like we are getting some floating point inconsistencies on x86_64-unknown-linux-musl now. We already had issues on i586 before where we disabled the tests, but we should probably do a more robust hashing algorithm suited for images where tiny differences don't cause the hash to change.