Expanded Testing Capabilities to support GLWACSO Test Case #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch upstream commits into `wq-updates-tmr` to squash merge conflicts
Testing against HSPF still ongoing
Pull in latest WQ update into testing branch for more up to date comparision
These files are too large to commit to the repo, so for the time being we'll gitignore them to keep them for interfering with commits.
Replaces regression_base run_one_test method with methods that single responsibility Introduces multithreading support
Member
Author
|
Latest round of commits restructures the core RegressTest class to make it more performant and easier to maintain and extend in the future. Summary of updates include:
|
Update testing branch with latest model code.
Member
Author
|
@tredder75 @aufdenkampe |
This was referenced Oct 1, 2021
Merge LimnoTech RQUAL class approach, GENER, expanded testing to RESPEC
develop
respec/HSPsquared#61
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The current testing infrastructure for comparison with HSPF and HSP2 consists of the single test10 scenario. With the addition of the water quality modules (reference PR #39), the testing scenarios should be expanded to include models which utilize the water quality features.
Solution:
This branch makes minor tweaks to the existing unit testing class developed by @tong.zhai to support the GLSACSO test case.
Testing:
The revised test class was executed for the GLWACSO scenario to confirm that a test_report_conversion.html document would be correctly generated.
Addresses: