Skip to content

drop unused variable in ModelCheckpoint#6344

Closed
akihironitta wants to merge 2 commits intoLightning-AI:masterfrom
akihironitta:refactor/unused2
Closed

drop unused variable in ModelCheckpoint#6344
akihironitta wants to merge 2 commits intoLightning-AI:masterfrom
akihironitta:refactor/unused2

Conversation

@akihironitta
Copy link
Copy Markdown
Contributor

@akihironitta akihironitta commented Mar 4, 2021

What does this PR do?

Follow up of #6308.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

tchaton
tchaton approved these changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

akihironitta
akihironitta commented Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping pl_module in save_checkpoint(self, trainer, pl_module) because it's a public method.
https://github.com/PyTorchLightning/pytorch-lightning/blob/1cc43ba7b2054d323533f9893c365fb45176376d/pytorch_lightning/callbacks/model_checkpoint.py#L207

@akihironitta akihironitta marked this pull request as ready for review March 4, 2021 13:03
@carmocca
Copy link
Copy Markdown
Contributor

carmocca commented Mar 4, 2021

Duplicate of #6136

@carmocca carmocca marked this as a duplicate of #6136 Mar 4, 2021
@carmocca carmocca mentioned this pull request Mar 4, 2021
Merged
10 tasks
@akihironitta akihironitta deleted the refactor/unused2 branch March 5, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Awaiting requested review from Borda

@carmocca carmocca Awaiting requested review from carmocca

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akihironitta @carmocca @tchaton