Skip to content

drop deprecated docs & fix isort#5768

Merged
Borda merged 3 commits intorelease/1.2-devfrom
docs/drop-acc-plug
Feb 3, 2021
Merged

drop deprecated docs & fix isort#5768
Borda merged 3 commits intorelease/1.2-devfrom
docs/drop-acc-plug

Conversation

@Borda
Copy link
Copy Markdown
Collaborator

@Borda Borda commented Feb 3, 2021 •
edited
Loading

What does this PR do?

drop docs for deprecated accelerators and plugins
following @edenlightning request

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Feb 3, 2021
@Borda Borda added this to the 1.2 milestone Feb 3, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2021 •
edited
Loading

Codecov Report

Merging #5768 (f04be32) into release/1.2-dev (aba2123) will decrease coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5768    +/-   ##
================================================
- Coverage               88%     88%    -0%     
================================================
  Files                  181     181            
  Lines                12890   12741   -149     
================================================
- Hits                 11339   11158   -181     
- Misses                1551    1583    +32

@Borda Borda enabled auto-merge (squash) February 3, 2021 16:09
@Borda Borda added the priority: 1 Medium priority task label Feb 3, 2021
@Borda Borda mentioned this pull request Feb 3, 2021
Merged
@Borda Borda added the ready to be merged PRs ready to be merged label Feb 3, 2021
@Borda Borda changed the title drop deprecated docs drop deprecated docs & fix isort Feb 3, 2021
@Borda Borda merged commit 630a88a into release/1.2-dev Feb 3, 2021
@Borda Borda deleted the docs/drop-acc-plug branch February 3, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton Awaiting requested review from tchaton

@carmocca carmocca Awaiting requested review from carmocca

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

3 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@edenlightning edenlightning edenlightning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation related priority: 1 Medium priority task ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Borda @awaelchli @SeanNaren @edenlightning