Skip to content

resolve cyclic import issues in utilities#5256

Merged
Borda merged 3 commits intorelease/1.2-devfrom
refactor/avail-imports
Dec 29, 2020
Merged

resolve cyclic import issues in utilities#5256
Borda merged 3 commits intorelease/1.2-devfrom
refactor/avail-imports

Conversation

@Borda
Copy link
Copy Markdown
Collaborator

@Borda Borda commented Dec 23, 2020 •
edited
Loading

What does this PR do?

Resolving some cyclic import issues

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Dec 23, 2020
@Borda Borda added this to the 1.2 milestone Dec 23, 2020
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Dec 23, 2020 •
edited
Loading

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-24 22:01:09 UTC

@Borda Borda changed the title clean avail. imports clean avail. imports & enums Dec 23, 2020
@Borda Borda marked this pull request as ready for review December 23, 2020 23:42
@Borda Borda force-pushed the refactor/avail-imports branch from dfa3e0e to fe9415f Compare December 24, 2020 22:01
@Borda Borda enabled auto-merge (squash) December 24, 2020 22:02
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2020

Codecov Report

Merging #5256 (fe9415f) into release/1.2-dev (2718d7d) will increase coverage by 0%.
The diff coverage is 95%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5256   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  140     142    +2     
  Lines                10010   10014    +4     
===============================================
+ Hits                  9297    9301    +4     
  Misses                 713     713

@Borda Borda self-assigned this Dec 29, 2020
@Borda Borda added the ready to be merged PRs ready to be merged label Dec 29, 2020
@Borda Borda changed the title clean avail. imports & enums Resolving some cyclic import issues Dec 29, 2020
@awaelchli awaelchli changed the title Resolving some cyclic import issues resolve cyclic import issues in utilities Dec 29, 2020
@Borda Borda merged commit ae9956f into release/1.2-dev Dec 29, 2020
@Borda Borda deleted the refactor/avail-imports branch December 29, 2020 18:02
@Borda Borda mentioned this pull request Jan 11, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@lezwon lezwon Awaiting requested review from lezwon

@yukw777 yukw777 Awaiting requested review from yukw777

4 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@s-rog s-rog s-rog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Borda Borda

Labels

ready to be merged PRs ready to be merged refactor

Projects

None yet

Milestone

pl:1.2

Development

Successfully merging this pull request may close these issues.

6 participants

@Borda @pep8speaks @awaelchli @carmocca @rohitgr7 @s-rog