Skip to content

Add MPS accelerator support for mixed precision#21209

Merged
bhimrazy merged 12 commits intoLightning-AI:masterfrom
bhimrazy:feature/mps-amp-support
Sep 25, 2025
Merged

Add MPS accelerator support for mixed precision#21209
bhimrazy merged 12 commits intoLightning-AI:masterfrom
bhimrazy:feature/mps-amp-support

Conversation

@bhimrazy
Copy link
Copy Markdown
Collaborator

@bhimrazy bhimrazy commented Sep 14, 2025 •
edited
Loading

What does this PR do?

This PR adds proper MPS (Apple Silicon GPU) accelerator support for mixed precision training by fixing device selection logic and adding comprehensive tests.

Fixes #14358

to be checked for: #20497
fabric got it in #20876

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 14, 2025
@bhimrazy bhimrazy self-assigned this Sep 14, 2025
@bhimrazy bhimrazy added the accelerator: mps Apple Silicon GPU label Sep 14, 2025
SkafteNicki
SkafteNicki reviewed Sep 15, 2025
View reviewed changes
@bhimrazy bhimrazy merged commit 9d40bc8 into Lightning-AI:master Sep 25, 2025
84 of 85 checks passed
@bhimrazy bhimrazy deleted the feature/mps-amp-support branch September 25, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@lantiga lantiga Awaiting requested review from lantiga

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

@bhimrazy bhimrazy

Labels

accelerator: mps Apple Silicon GPU pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MPS AMP Support

3 participants

@bhimrazy @Borda @SkafteNicki