Replace using_pjrt() xla runtime device_type() check with in xla.py for torch-xla>=2.5#20442
Merged
lantiga merged 6 commits intoLightning-AI:masterfrom Nov 25, 2024
Merged
Replace using_pjrt() xla runtime device_type() check with in xla.py for torch-xla>=2.5#20442lantiga merged 6 commits intoLightning-AI:masterfrom
using_pjrt() xla runtime device_type() check with in xla.py for torch-xla>=2.5#20442lantiga merged 6 commits intoLightning-AI:masterfrom
Conversation
Fixes Lightning-AI#20419 `torch_xla.runtime.using_pjrt()` is removed in pytorch/xla#7787 This PR replaces references to that function with a check to [`device_type()`](https://github.com/pytorch/xla/blob/master/torch_xla/runtime.py#L83) to recreate the behavior of that function, minus the manual initialization
using_pjrt() xla runtime device_type() check with in xla.pyusing_pjrt() xla runtime device_type() check with in xla.py for torch-xla>=2.5
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20442 +/- ##
=======================================
- Coverage 88% 88% -0%
=======================================
Files 267 267
Lines 23203 23207 +4
=======================================
+ Hits 20313 20315 +2
- Misses 2890 2892 +2 |
tchaton
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20419
torch_xla.runtime.using_pjrt()is removed in pytorch/xla#7787If torch_xla version >= 2.5, this PR replaces references to that function with a check to
device_type()to recreate the behavior of that function, minus the manual initializationBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20442.org.readthedocs.build/en/20442/